This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix PR28516 (Arm nested function ICE)

From: Mark Mitchell <mark at codesourcery dot com>
To: Paul Brook <paul at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 20 Sep 2006 17:33:40 -0400
Subject: Re: Fix PR28516 (Arm nested function ICE)
References: <200609191419.19477.paul@codesourcery.com>

Paul Brook wrote:

+     else if (GET_CODE (e1) == PLUS
+	      && GET_CODE (XEXP (e1, 0)) == REG
+	      && REGNO (XEXP (e1, 0)) == SP_REGNUM
+	      && GET_CODE (XEXP (e1, 1)) == CONST_INT)
+	{
+	  /* Set reg to offset from sp.  */
+	  asm_fprintf (asm_out_file, "\t.movsp %r, #%d\n",
+		       REGNO (e0), (int)INTVAL(XEXP (e1, 1)));
+	}

Least substantive comment of the day: I think the coding standards say that you should remove the braces, since you've only got a single dependent statement. (The comment doesn't count.)

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

Follow-Ups:
- Re: Fix PR28516 (Arm nested function ICE)
  - From: Paul Brook

References:
- Fix PR28516 (Arm nested function ICE)
  - From: Paul Brook

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]