This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Fix middle-end/25505

From: Mark Mitchell <mark at codesourcery dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: Eric Botcazou <ebotcazou at libertysurf dot fr>, Roger Sayle <roger at eyesopen dot com>, gcc-patches at gcc dot gnu dot org, Josh Conner <jconner at apple dot com>, jason at redhat dot com, richard dot guenther at gmail dot com
Date: Wed, 20 Sep 2006 17:17:15 -0400
Subject: Re: PATCH: Fix middle-end/25505
References: <Pine.LNX.4.44.0609192125190.9097-100000@www.eyesopen.com> <200609200904.02384.ebotcazou@libertysurf.fr> <m3bqpb3tp4.fsf@localhost.localdomain>

Ian Lance Taylor wrote:

Eric Botcazou <ebotcazou@libertysurf.fr> writes:

IMHO the reviewer should make a decision upfront: either the patch is safe enough for the release branch and it must be applied simultaneously on both branches, or it is not and the PR should be marked as WONTFIX on the release branch (unless a safer patch can be devised for the branch).
While you make good points, I don't agree that this is an appropriate
general rule.  I think we have to decide based on the situation.

FWIW, I agree with everyone: (a) it's sometimes a good idea to apply patches just to mainline, as a way of getting more validation before putting them into a release branch, (b) it's overkill to do that "always".

My two cents,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

References:
- Re: PATCH: Fix middle-end/25505
  - From: Roger Sayle
- Re: PATCH: Fix middle-end/25505
  - From: Eric Botcazou
- Re: PATCH: Fix middle-end/25505
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]