Re: back out dwarf2out_stack_adjust change

[Alexandre Oliva <aoliva at redhat dot com>]

On Sep  2, 2006, gkeating@apple.com (Geoffrey Keating) wrote:

> Mark would prefer that I just back out Alexandre's change.

Thanks for, erhm, not letting my disappearance get in the way of
progress (I can't figure out a way to write it in such a way that it
can't possibly be read as ironic, but I can't, so let me just explain
that I'm being honest, not ironic :-)

Sorry about my extended silence.

> While preparing this change, I found out that although the C and C++
> frontends never emit nested function calls that can throw, the Java
> frontend can call library routines which can throw.
> Fortunately, the Java frontend uses asynchronous unwind tables and so
> removing Alexandre's change does not affect it.

Good.

> Here's what you'd need to do to make this routine really work:

Would it make sense to add a FIXME comment to that function, with your
bullets and a pointer to the patch that was reverted?  Or maybe just a
pointer to your e-mail with the reverted patch?

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Secretary for FSF Latin America        http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}