This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Compile time buffer overflow checks for strncat
- From: Geoffrey Keating <geoffk at apple dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 18 Sep 2006 13:28:47 -0700
- Subject: Re: [PATCH] Compile time buffer overflow checks for strncat
- References: <20060918185549.GZ12531@devserv.devel.redhat.com>
Jakub Jelinek <jakub@redhat.com> writes:
> 2006-09-18 Jakub Jelinek <jakub@redhat.com>
>
> * tree-ssa-propagate.c (set_rhs): Copy EXPR_LOCATION if
> needed.
This is OK.
> * builtins.c (expand_builtin, maybe_emit_chk_warning): Handle
> BUILT_IN_STRNCAT_CHK.
Don't you need to change fold_builtin_1 too?
> * gcc.dg/builtin-strncat-chk-1.c: New test.
This part is fine.