This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH RESEND] Actually use argument in documentation example for __builtin_types_compatible_p
- From: Geoffrey Keating <geoffk at apple dot com>
- To: Josh Triplett <josht at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 11 Sep 2006 14:24:09 -0700
- Subject: Re: [PATCH RESEND] Actually use argument in documentation example for __builtin_types_compatible_p
- References: <1151687777.6507.71.camel@josh-work.beaverton.ibm.com> <44A8C5FB.2050204@lu.unisi.ch> <1158006727.4373.37.camel@josh-work.beaverton.ibm.com>
Josh Triplett <josht@us.ibm.com> writes:
> The documentation example for __builtin_types_compatible_p consists of a
> macro which takes an argument x of some type. The macro declares a
> temporary tmp of the same type, then uses __builtin_types_compatible_p
> to dispatch to one of three functions based on the type of x. However,
> the macro does not actually use its argument x at all, but instead
> passes the uninitialized tmp to the appropriately-typed function. This
> patch fixes the macro to actually use its argument.
>
> I don't have commit access, so would someone with commit access please
> commit this patch? As a documentation fix, this should qualify for GCC
> 4.2, and to 4.1 or 4.0 if anyone wants to apply it there.
>
> Thanks,
> Josh Triplett
>
> ChangeLog entry:
> 2006-07-05 Josh Triplett <josh@freedesktop.org>
>
> * gcc/doc/extend.texi: Actually use the macro argument in the
> documentation example for __builtin_types_compatible_p.
Hi Josh,
This is OK, and I'll commit it.