This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [addrmodes] Tame LEGITIMIZE_ADDRESS / Refactoring for mode-dependent addresses
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>, shinwell at codesourcery dot com
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 5 Sep 2006 21:39:18 -0400 (EDT)
- Subject: Re: [addrmodes] Tame LEGITIMIZE_ADDRESS / Refactoring for mode-dependent addresses
- References: <44ED5C6B.6090103@lu.unisi.ch>
On Thu, 24 Aug 2006, Paolo Bonzini wrote:
> At the same time I'm
> removing the last occurrences of GO_IF_LEGITIMATE_ADDRESS in
> machine-dependent code.
>
> In addition, defining LEGITIMIZE_ADDRESS is now optional.
(Sorry, can't quote attached patches in pine.)
Please, no "{}" or "do {} while (0)" definitions: when
necessary, empty works just as well.
When applicable, removing the macro as a mandatory definition
is, as you did right, but please no commented-out macro
definition. If there's a comment that deserves keeping, append
to it something like: ", but now handled by the default
definition/code, making this comment about LEGITIMIZE_EXISTENCE
historical" but please remove the macro definition completely,
don't comment it out.
This sweeping comment was for your changes as well as Mark Shinwell's
> * config/cris/cris.h (GO_IF_MODE_DEPENDENT_ADDRESS): Change to no-op.
and any similar ones.
brgds, H-P
PS. Thanks for your work!