This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [boehms-gc] Fix ggc-boehm cache hash table support

From: Paolo Bonzini <paolo dot bonzini at polimi dot it>
To: Laurynas Biveinis <laurynas dot biveinis at gmail dot com>
Cc: Daniel Berlin <dberlin at dberlin dot org>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tromey at redhat dot com>
Date: Wed, 16 Aug 2006 08:50:04 +0200
Subject: Re: [boehms-gc] Fix ggc-boehm cache hash table support
References: <d1e3ff2b0608110516x794ef2d5yfb879d187e3cc7d@mail.gmail.com> <m3zme72tf8.fsf@localhost.localdomain> <d1e3ff2b0608150922s8fd2454r9acdb417626363cc@mail.gmail.com>

I was curious to know why you didn't simply swap the values of
HTAB_EMPTY_ENTRY and HTAB_DELETED_ENTRY.  That would let the existing
"disappearing link" code in the GC do the right thing with htabs.


I simply didn't think of this :) OTOH, I don't like the fact that such
solution would work just by coincidence :) Moreover, you still have to
update hash table deletion statistics somehow.


Plus, various places would break; we're using memset in htab_empty, and
calloc/xcalloc in htab_create/htab_try_create. :-)

Paolo

References:
- [boehms-gc] Fix ggc-boehm cache hash table support
  - From: Laurynas Biveinis
- Re: [boehms-gc] Fix ggc-boehm cache hash table support
  - From: Tom Tromey
- Re: [boehms-gc] Fix ggc-boehm cache hash table support
  - From: Laurynas Biveinis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]