This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] [struct-reorg] port to ssa - 47% on art on ppc
- From: Olga Golovanevsky <OLGA at il dot ibm dot com>
- To: Daniel Berlin <dberlin at dberlin dot org>
- Cc: gcc-patches at gcc dot gnu dot org, Jan Hubicka <jh at suse dot cz>
- Date: Wed, 16 Aug 2006 01:03:26 +0300
- Subject: Re: [patch] [struct-reorg] port to ssa - 47% on art on ppc
Dan,
Thank you for comments. Preparing fixes.
Daniel Berlin <dberlin@dberlin.org> wrote on 15/08/2006 15:54:46:
>
> Please instead use call_expr_flags (<CALL_EXPR>) & ECF_MALLOC
thank you for tip. I only wonder whether ECF_MALLOC stands for all
allocation functions, i.e. malloc, calloc, realloc, xmalloc, or only for
malloc?
>
> It would also be nice to split up functions like create_new_mallocs.
>
> They look to be about 400 lines long (but it could just be the amount of
> changes that is making it look like that)
no problem. it's obviously can be split into two parts.
>
> I see you do some checks for TARGET_MEM_REF.
>
> You will *never* see TARGET_MEM_REF unless your code runs after ivopts.
if so, what was it that replaced former MEM_REF?
This code is commented out in ipa-type-escape.c:
/* || TREE_CODE (t) == MEM_REF) */
>
> I see a lot of xmalloc's, but not too many frees.
> Are you really freeing all this xmalloc'd memory you are allocating?
true. legacy :)
>
> --Dan