This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] one-liner: deinline gcc/tree-vrp.c vrp_int_const_binop()
- From: Denis Vlasenko <vda dot linux at googlemail dot com>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: Daniel Berlin <dannyb at google dot com>, H?kan Hjort <hakan at jasper-da dot com>, Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sat, 12 Aug 2006 16:37:25 +0200
- Subject: Re: [PATCH] one-liner: deinline gcc/tree-vrp.c vrp_int_const_binop()
- References: <200608121533.58521.vda.linux@googlemail.com> <20060812140247.GA13707@atrey.karlin.mff.cuni.cz>
On Saturday 12 August 2006 16:02, Zdenek Dvorak wrote:
> Helo,
>
> > * tree-vrp.c (vrp_int_const_binop): deinline it
>
> please follow the conventions regarding the format of changelog
> messages.
Like this?
2006-08-12 Denis Vlasenko <vda.linux@googlemail.com>
* tree-vrp.c (vrp_int_const_binop): deinline it
Should I put a tab there or spaces? Exactly 8 spaces?
Do I need to have empty lines, where, and how many?
http://www.gnu.org/prep/standards/standards.html
is not consistent about it.
> > There are two dozens of calls to that function.
> > Before/after code size comparison:
> >
> > # size tree-vrp_inline.o tree-vrp_noinline.o
> > text data bss dec hex filename
> > 47147 52 24 47223 b877 tree-vrp_inline.o
> > 44273 52 24 44349 ad3d tree-vrp_noinline.o
> >
> > This patch was compile-tested.
>
> even trivial patches like this need full bootstrap and regtesting. The
> reason is that even though this change is obviously harmless, it might
> uncover some latent bug (the things will be optimized differently
> depending on whether vrp_int_const_binop is inlined or not).
--
vda