This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH for debug/28063 - disabled string merging


On Tue, Aug 01, 2006 at 10:27:07AM -0400, Daniel Jacobowitz wrote:
> Does this version look good to you?
> 
> 2006-08-01  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	PR debug/28063
> 	* gcc.dg/debug/dwarf2/dwarf-merge.c: New test.
> 	* lib/target-supports.exp (get_compiler_messages): Add WANT_CONTENTS.
> 	Optionally return assembly text.  Update callers.
> 	(check_no_messages_and_pattern): New.
> 	(check_effective_target_string_merging): New.

Mostly good; fix the comment for WANT_OUTPUT, which says it returns
the object or assembly file.  Also fix the verbose messages from
check_no_compiler_messages and check_no_messages_and_pattern, which
say they're from check_effective_target; I tend to use messages like
that a lot when debugging the testsuite infrastructure.  OK with those
changes.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]