This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for regression PR c++/28432
- From: Steve Ellcey <sje at cup dot hp dot com>
- To: mark at codesourcery dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 1 Aug 2006 09:34:32 -0700 (PDT)
- Subject: Re: Patch for regression PR c++/28432
Mark Mitchell Wrote:
> Steve Ellcey wrote:
>
> > + if (!IS_AGGR_TYPE_CODE (TREE_CODE (xbasetype)))
> > + return NULL_TREE;
>
> Please use "!CLASS_TYPE_P (xbasetype)". That will cause the condition
> to be false for pointers to member functions as well, which makes sense;
> we should never be doing lookup on a pointer to member function.
> However, it's just possible that we *are* doing that, out of laziness,
> so if the patch fails any tests with that change, go with your version
> instead.
>
> Patch OK with that change, or, as above, without if necessary.
FYI: Using !CLASS_TYPE_P did cause quite a few testsuite failures so I
will check this in as I originally submitted it.
Steve Ellcey
sje@cup.hp.com