This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [dataflow] PATCH committed to fix debugging info.
- From: Daniel Berlin <dberlin at dberlin dot org>
- To: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- Cc: Kenneth Zadeck <zadeck at naturalbridge dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 28 Jul 2006 06:36:32 -0400
- Subject: Re: [dataflow] PATCH committed to fix debugging info.
- References: <44C8C370.2060905@naturalbridge.com> <44C96B4A.8000908@lu.unisi.ch>
Paolo Bonzini wrote:
>> The solution to these problems is that df privately has a pointer to the
>> latest df instance created that it makes available to the dumpers and
>> that a new TODO was created to call df_finish on this instance after the
>> dumpers have run. Thus, most of the calls to df_finish have been
>> replaced by additions of this flag to the pass manager structure.
>>
> Hi Kenny, I'm sorry to say that I don't like this aspect of this patch
> (I like the rest pretty much).
>
> I don't like, even though there is no need for it right now, that the
> creation of data flow objects cannot be nested.
Sure it can. It's just that if you have one long running instance, this
is the way to clean it up.
If you want to make it a property instead of a todo flag, go for it, i
don't see too much difference here (prop flags don't allow you to nest
either).