This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran,commited] Add g77 intrinsics LSTAT, MCLOCK, MCLOCK8, LONG, SHORT, INT2 and INT8
- From: Paul Brook <paul at codesourcery dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: "François-Xavier Coudert" <fxcoudert at gmail dot com>, gfortran <fortran at gcc dot gnu dot org>
- Date: Thu, 27 Jul 2006 16:43:39 +0100
- Subject: Re: [gfortran,commited] Add g77 intrinsics LSTAT, MCLOCK, MCLOCK8, LONG, SHORT, INT2 and INT8
- References: <19c433eb0607260506k16dec3faxc0fc1e1fb321d154@mail.gmail.com>
> http://gcc.gnu.org/viewcvs?view=rev&revision=115754
Convention is to attach the patch anyway.
> Since gfortran activity has been low-level these days, I'm commiting
> that under a stretch of the "obvious" rule. I hope this is not
> stretching it too far, if you're concerned or annoyed about that
> please say so.
I think you're stretching it too far. The obvious rule is intended for
bugfixes that are the fix is so simple that noone could possibly object.
The LSTAT intrinsic is definitely non-obvious in this context. IIRC some
targets (eg. windows) don't have all the different stat variants.
Also consider that we're in stage 3, and this looks a lot like a new feature.
Having said that you are listed as a Fortran maintainer, so you have some
leeway to check in your own patches.
Paul