Re: [Committed] Fix compilation warnings in i386/gmon-sol2.c

[Rainer Orth <ro at TechFak dot Uni-Bielefeld dot DE>]

Roger Sayle <roger@eyesopen.com> writes:

> The following patch resolves the large number of compilation warnings
> when building config/i386/gmon-sol2.c.  Interestingly, after bootstrapping
> and regression testing the changes below to update gmon-sol2.c to ISO C
> from K&R, by backporting the clean-ups made to sparc/gmon-sol2.c, I
> discovered that Rainer Orth had proposed a very similar patch back in
> November 2003!  http://gcc.gnu.org/ml/gcc-patches/2003-11/msg00251.html
> 
> In the patch below I've credited Rainer as co-author, as his changes
> are almost identical to mine, just developed independently many months
> earlier.

Thanks for doing this.  I probably forgot about that patch when it wasn't
necessary any longer to avoid the bootstrap failure introduced by using
-Werror for all backend code.

As a second step, it would probably be useful to completely merge the two
instances of gmon-sol2.c since the differences are not that large any
longer.  I have this on my agenda since the original patch submission :-)

> Just as I was composing this e-mail, I realized that rather than mention
> that the GCC project doesn't have an official Solaris port maintainer,

True enough, unfortunately.  While Solaris/SPARC is well taken care of by
Eric Botcazou, Solaris/x86 is quite an unloved child ;-(  I complained
about this on the tools-gcc mailing list on OpenSolaris.ORG

	http://www.opensolaris.org/jive/thread.jspa?threadID=6799&tstart=0
	http://www.opensolaris.org/jive/thread.jspa?threadID=6911&tstart=0

but didn't get many reactions or even support.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University