This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto] Add nth_parm_type_p, alloc_parm_types, vec_heap2parm_types.


Mark Mitchell <mark@codesourcery.com> writes:

> Kazu Hirata wrote:
> > Hi Mark,
> > 
> >>>>> *(nth_parm_type_p (parm_types, 3)) = some_type;
> >>>>
> >>>>
> >>>> Would set_parm_type (parm_types, 3, some_type) be a simpler interface?
> >>>>
> >>>> I'm OK with either option, but pointers always tend to require a bit
> >>>> more thought.
> >>>
> >>> OK.  How about introducing both set_parm_type and nth_parm_type_ptr? 
> >>
> >>
> >> Only if you think it's convenient; you're the one using the interface.
> >> :-)  If you need the pointer interface, and you're happy to use it,
> >> stick with that.
> > 
> > OK.  In that case, is the original patch approved with
> > s/nth_parm_type_p/nth_parm_type_ptr/?
> 
> Yes, thanks.  (If Ian has objections, please correct as he suggests.)

I have no objections.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]