This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Fix finish_static_data_member_decl (PR c++/28370)

From: Jason Merrill <jason at redhat dot com>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Sat, 15 Jul 2006 16:15:22 -0400
Subject: Re: [C++ PATCH] Fix finish_static_data_member_decl (PR c++/28370)
References: <20060713205231.GL32572@devserv.devel.redhat.com> <44B82FB1.20606@codesourcery.com>

Mark Mitchell wrote:

-  if (! processing_template_decl && TREE_PUBLIC (decl))
+  if (! processing_template_decl)
     note_vague_linkage_var (decl);


This doesn't make sense, as things without TREE_PUBLIC don't have vague
linkage.

Sure they can. We've previously handled vague linkage for targets without weak symbol support by clearing TREE_PUBLIC.

> However, note_vague_linkage_var only has one caller, and all

it does is put things on the pending statics list, so just inline it
here.  OK with that change.

But I'm fine with this change.

Jason

References:
- [C++ PATCH] Fix finish_static_data_member_decl (PR c++/28370)
  - From: Jakub Jelinek
- Re: [C++ PATCH] Fix finish_static_data_member_decl (PR c++/28370)
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]