This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] factor code common to all builtin_function implementations



On 30/06/2006, at 5:18 PM, Rafael Espíndola wrote:


On 6/29/06, Geoff Keating <geoffk@geoffk.org> wrote:
Hi Rafael,
Hi Geoff

This large patch:

2006-05-02 Rafael Ávila de Espíndola <rafael.espindola@gmail.com>

* gcc/java/decl.c: Include langhooks.h.
(builtin_function): Remove.
(java_init_decl_processing): Replace calls to builtin_function
with add_builtin_function.
...


is OK.

For trunk or LTO? Should I way untill trunk is in stage1?

It's OK for trunk (and so OK everywhere else, usually), but you still can't commit it to the trunk at the moment because it's not a regression fix or even a bugfix. So you keep it until we get to stage1 but you don't need to have it reviewed again (unless you need to make non-obvious changes to it).




Attachment: smime.p7s
Description: S/MIME cryptographic signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]