This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Memory (de)allocation again..

Hi Thomas,

The attached patch corrects the defect and the testcase is modified
appropriately.


The attached patch is correct, except that I don't know why you're
checking for nonzero_arraylen not being NULL_TREE:

         if (nonzero_arraylen != NULL_TREE)
           se->expr = build2 (TRUTH_AND_EXPR, boolean_type_node,
                              se->expr, nonzero_arraylen);

since nonzero_arraylen is the result of a build2() call and we usually
use those without further checking. Apart from that, the patch looks
OK.

FX

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]