This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran/libgfortran] Remove abort_ symbol from libgfortran


On Sat, May 27, 2006 at 01:14:31AM +0300, Janne Blomqvist wrote:
> :ADDPATCH fortran:
> 
> Hi,
> 
> now that Steve Kargl has added the -fall-intrinsics option, there is
> no need to expose an abort_ symbol for the testsuite. The attached
> patch removes that symbol (the functionality is still available via
> _gfortran_abort), and adds -fall-intrinsics to those testcases that
> use -std=f95 or -std=f2003 and call abort.
> 
> Regtested on i686-pc-linux-gnu. Ok for trunk?
> 

Looks ok to me.

I think we should also remove the local hack for exposing
etime_.  The correct fix is to remove the "external etime"
form the LAPACK file.

-- 
Steve

Index: etime.c
===================================================================
--- etime.c	(revision 113673)
+++ etime.c	(working copy)
@@ -93,25 +93,3 @@ etime (gfc_array_r4 *t)
   etime_sub (t, &val);
   return val;
 }
-
-/* LAPACK's test programs declares ETIME external, therefore we
-   need this.  */
-
-extern GFC_REAL_4 etime_ (GFC_REAL_4 *t);
-export_proto_np(etime_);
-
-GFC_REAL_4
-etime_ (GFC_REAL_4 *t)
-{
-  gfc_array_r4 desc;
-  GFC_REAL_4 val;
-
-  /* We only fill in the fields that are used in etime_sub.  */
-  desc.dim[0].lbound = 0;
-  desc.dim[0].ubound = 1;
-  desc.dim[0].stride = 1;
-  desc.data = t;
-
-  etime_sub (&desc, &val);
-  return val;
-}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]