This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFT/RFA] bashjar patch


Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 113241)
> +++ configure.ac	(working copy)
> @@ -116,9 +116,18 @@ AC_CHECK_TOOL(AS, as)
>  AC_CHECK_TOOL(LD, ld)
>  AC_CHECK_TOOL(AR, ar)
>  AC_CHECK_TOOL(RANLIB, ranlib, :)
> -AC_CHECK_PROGS(JAR, [jar fastjar], false)
> -if test "$JAR" = false; then
> -  AC_MSG_ERROR(jar program not found)
> +AC_PROG_AWK
> +AC_CHECK_PROGS([JAR], [jar fastjar], no)
> +AC_PATH_PROG([ZIP], [zip], no)
> +AC_PATH_PROG([UNZIP], [unzip], unzip)
> +AM_CONDITIONAL(BASH_JAR, test "$JAR" = no)
> +if test "$ZIP" = no; then
> +  if test "$JAR" = no; then
> +    AC_MSG_ERROR([cannot find neither zip nor jar, cannot continue])
> +  fi
> +else
> +  # InfoZIP available, use the 'guaranteed' Bourne-shell JAR to build libjava
> +  JAR=`pwd`/scripts/jar
>  fi

I think this is backwards.  You are always using the shell jar when zip is
available, even if a jar program was found.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]