This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix some weird IVOPTs choices (part of PR26726)
- From: Richard Guenther <rguenther at suse dot de>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 1 May 2006 17:10:09 +0200 (CEST)
- Subject: Re: [PATCH] Fix some weird IVOPTs choices (part of PR26726)
- References: <Pine.LNX.4.44.0605010811420.26465-100000@www.eyesopen.com>
On Mon, 1 May 2006, Roger Sayle wrote:
> > 2006-04-27 Richard Guenther <rguenther@suse.de>
> >
> > PR tree-optimization/26726
> > * tree-ssa-loop-ivopts.c (idx_find_step): Mark source of the
> > problem ...
> > (find_interesting_uses_address): ... we work around here
> > by folding INDIRECT_REFs in the substituted base.
> >
> > * g++.dg/tree-ssa/ivopts-1.C: New testcase.
>
> This is Ok for mainline. Thanks.
>
>
> One minor style suggestion though. The new "tree *ref" variable is
> only used inside the scope of your new if, so it's possible to move
> the declaration there, and even combine it with its initialization.
> But this is just a personal preference, and your patch is fine as
> written.
Applied with the suggested change.
Thanks,
Richard.