This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] pragma for ms_struct


On Apr 27, 2006, at 12:34 PM, Geoffrey Keating wrote:
On 27/04/2006, at 9:42 AM, Eric Christopher wrote:

So, here's the last patch. After talking with geoff yesterday he mentioned that I should unify the code in the darwin files which this does. It also makes it a little easier if people decide it's more useful as a general option. All of this helped minimize the effects on non-darwin ports for now as well. Next will be the patches to fix up the attribute.

Tested on x86-darwin, ppc-darwin.

OK?

I'm pretty sure the target-def.h change is wrong; notice the way that there's nothing like that for any other macro in target-def.h.

Eh? Sure there is. There's even a comment explaining why you'd need to do this:


/* Note that if one of these macros must be defined in an OS .h file
rather than the .c file, then we need to wrap the default
definition in a #ifndef, since files include tm.h before this one. */


Elsewhere in this file, I happened to notice this:

#ifndef TARGET_ARM_TTYPE
#define TARGET_ASM_TTYPE hook_bool_rtx_false
#endif

which looks like a typo, but I don't understand what it's doing well enough to be sure...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]