This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] RFT, remove of lint directives in libffi
- From: Andrew Haley <aph at redhat dot com>
- To: Andreas Tobler <toa at pop dot agri dot ch>
- Cc: Java Patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tromey at redhat dot com>, Anthony Green <green at redhat dot com>
- Date: Thu, 20 Apr 2006 16:13:16 +0100
- Subject: Re: [patch] RFT, remove of lint directives in libffi
- References: <4446AABB.7000506@pop.agri.ch> <17479.20684.32340.630812@zapata.pink> <4447A3FB.8030502@pop.agri.ch>
Andreas Tobler writes:
> Andrew Haley wrote:
> > Andreas Tobler writes:
> > >
> > > I need some testers here.
> > > This patch tries to remove the lint directives from the libffi code.
> > > As far as I am aware, nobody uses this directives. So, I think for code
> > > cleanness it would be a first step to remove these.
> > >
> > > I can test on powerpc-linux, darwin, solaris and hp-ux. I do not expect
> > > a fallout, but to be sure it would be nice to have some more tests.
> > >
> > > The patch is against trunk.
> > >
> > > If tests go fine, ok for trunk?
> >
> > This patch also deletes ffitest.c.
>
> Yes, I mentioned it in the CL.
With no explanation at all! :-)
> Do you want to keep it? And if so, why?
> All tests from this file have been integrated into the test suite when I
> introduced the dejagnu based suite.
>
> I'll certainly keep it if you feel we should. I just thought it is no
> longer needed.
You should say so in your patch submission, then. I have no feelings
either way.
Andrew.