This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [avr]: conversion to define_constraint
- From: Zack Weinberg <zackw at panix dot com>
- To: Denis Chertykov <denisc at overta dot ru>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 27 Mar 2006 20:05:17 -0500
- Subject: Re: [avr]: conversion to define_constraint
Denis Chertykov wrote:
> I have converted avr port to define_constraint ...
Cool.
(I remind everyone that I don't have approval authority anymore, but ...)
This patch also converts some #defines and some magic numbers to
a (define_constants [...]) form. It would ease review if you did that in
a separate patch. I don't see any intrinsic reason why they have to go
together.
You need to update doc/md.texi::Machine Constraints to point readers at
config/avr/constraints.md instead of config/avr/avr.h. (Or if there is
not already an AVR subsection, add one, using the docstrings you wrote.)
You put the bulk of the logic for constraint "Q" in an avr.c function, which
is called only from the constraint definition. Would you prefer to be able
to write a C code block in the constraint definition, as can be done for
predicates? It would not be hard to add support for this to genpreds.
[I am willing to code this but not till early April.]
Other than that looks good, though I have not close-read the conversion
for semantic equivalence or anything like that.
zw