This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ Visibility regressions
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: David Edelsohn <dje at watson dot ibm dot com>
- Cc: "gcc-patches >> GCC Patches" <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Wed, 22 Mar 2006 23:32:00 -0500
- Subject: Re: C++ Visibility regressions
- References: <200603230421.k2N4Lx426154@makai.watson.ibm.com>
On Mar 22, 2006, at 11:21 PM, David Edelsohn wrote:
Jason supplied the appended patch, which I tested on AIX and
committed with his approval from IRC.
David
* name-lookup.c (push_namespace_with_attribs): Only apply hidden
visibility to anonymous namespaces if HAVE_GAS_HIDDEN.
This is not the correct check in general since
TARGET_ASM_ASSEMBLE_VISIBILITY
can change to something different besides the default.
Darwin is one such target.
There is another one of this misusing of HAVE_GAS_HIDDEN in
targhooks.c (default_hidden_stack_protect_fail).
Also in gcov-io.h's use is wrong too.
HAVE_GAS_HIDDEN just says the the assembler support .hidden and not
if the target supports visibility.
-- Pinski