This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] add option to issue warning when trampolines are generated
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: "Kevin F. Quinn (Gentoo)" <kevquinn at gentoo dot org>
- Cc: gcc-patches at gcc dot gnu dot org, toolchain at gentoo dot org
- Date: Sat, 18 Mar 2006 14:41:46 +0000 (UTC)
- Subject: Re: [PATCH] add option to issue warning when trampolines are generated
- References: <20060318110314.6418edbc@c1358217.kevquinn.com>
On Sat, 18 Mar 2006, Kevin F. Quinn (Gentoo) wrote:
> + if (warn_trampolines)
> + warning (0, "generating trampolines in object (requires executable stack)");
We shouldn't add new warning (0, ...), you mean
warning (OPT_Wtrampolines, ...)
without the if. Testcases for the testsuite are needed as well (that the
warning is given when the new option is specified, but not when it isn't).
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
joseph@codesourcery.com (CodeSourcery mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)