This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Some operands building cleanups


On Thu, 2006-03-09 at 17:18 +0100, Zdenek Dvorak wrote:
> Hello,
> 
> > > -- finalize_ssa_def_ops and finalize_ssa_use_ops compare pointers that
> > >    do not belong to the same object by <, which is undefined.  However,
> > >    since the real operand lists are not sorted anyway, this is
> > >    unnecessary.
> > 
> > They are sorted so we can avoid a doubly nested loop.
> 
> no, they are not sorted.  append_{def,use} just collects them into
> build_{defs,uses} list in the order they are found, and the lists are
> never sorted.  Only the lists of virtual operands are sorted.
> 

Then its a latent bug and should be fixed. 

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]