This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Remove some unconditional SMT usage updates


> 
> On Fri, 2006-03-03 at 11:57 -0500, Diego Novillo wrote:
> > On 03/03/06 11:36, Daniel Berlin wrote:
> > 
> > > @@ -2194,6 +2196,7 @@ tree_sra (void)
> > >        scan_function ();
> > >        decide_instantiations ();
> > >        scalarize_function ();
> > > +      todoflags = TODO_update_smt_usage;
> > >
> > I would rather do this in either decide_instantiations.  If any var in
> > sra_candidates is an array, then flip TODO_update_smt_usage on todoflags
> > (and make todoflags a file static).
> > 
> 
> Okay.
> I mistakenly thought that if we get into this clause, we are definitely
> going to scalarize, but i see that is not true.
> 
> 
> > I don't think we SRA structures with arrays
> I believe Richard Guenther added the ability to do this.

That was added back in 4.0.0 when RTH rewrote tree-sra.c.
http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02515.html

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]