This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Fortran] Another round of WHERE statement optimizations


On Fri, Feb 17, 2006 at 12:10:07AM +0100, Steven Bosscher wrote:
> On Thursday 16 February 2006 22:34, Roger Sayle wrote:
> > Ok for mainline?
> 
> Is there some way to test that all of this works?  Improvements are
> always cool, but the gfortran test suite doesn't quite cover enough
> to be sure that just passing the usual bootstrap/testing cycle means
> that the patch is OK...
> 
> So while you're looking at this, maybe you can add some WHERE tests
> and somehow check that the transformations you're implementing are
> being applied correctly?
> 

The testsuite has several tests that use WHERE constructs.

gfortran.fortran-torture/execute:

  where_2.f90, where_4.f90, where_6.f90, where_8.f90
  where_1.f90, where_3.f90, where_5.f90, where_7.f90

gfortran.dg

  simpleif_1.f90, where_nested_1.f90:

gfortran.dg/gomp/appendix-a

  a.11.4.f90: 

While more test may be appealing, gfortran probably has enough tests
that if Roger made some drastic error we would catch it.   I plan to
review the patch this weekend.  I check the above tests and generate
others if needed.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]