Re: [patch] __TIMESTAMP__ predefined macro

[Grigory Zagorodnev <grigory_zagorodnev at linux dot intel dot com>]

Andrew Pinski wrote:
> A better way to write this changeLog is:
Ok. I'll be more laconic.

> +	        struct stat *st = _cpp_get_file_stat(file);
> Why not make a function which returns a pointer to the modification date instead of returning one
> to the stat?
Function _cpp_get_file_stat has to be extern and (IMHO) therefore 
somewhat universal. I see no reason to limit its interface.

> Also why don't you just use ctime or asctime instead of spelling it out?
This is correct. Describing __DATE__ and __TIME__ predefined macro in 
section 6.10.8, the C99 Standard refers asctime. Thus using 
asctime(localtime()) seems to be suitable solution. However the original 
idea was to follow existing cpplib approach for __DATE__ and __TIME__ 
string generation.

Thanks!
- Grigory