This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use "redefine_extname" with expansion under Solaris.


Mike Stump wrote:

> Rather than have 100 ports all ignoring this and having each port 
> slightly different, I think I'd rather have all ports do this 
> unconditionally and have any port that had to have it be machine 
> specific then be different.  Having them all different prevents 
> writting portable code, enable portable code is a nice goal of the 
> compiler.

I tend to agree, especially after noticing that our documentation
specifically says that we support this #pragma for compatibility with
SunPRO, which does the expansion.

So, Carlos, I'm going to simplify this patch for you: just change it
unconditionally to use c_register_pragma_with_expansion.  No target
header changes, no target documentation to write.  However, you do get
to update the wwwdocs/gcc-4.2/changes.html file, under language-specific
improvements, since this is a user-visible change in semantics.

That simple change is preapproved.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]