This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix libdecnumber bootstrap on Tru64 (part 2)
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: Richard Earnshaw <rearnsha at arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Ben Elliston <bje at au1 dot ibm dot com>
- Date: 20 Dec 2005 20:02:06 +0100
- Subject: Re: [PATCH] Fix libdecnumber bootstrap on Tru64 (part 2)
- References: <Pine.LNX.4.44.0512200952220.19693-100000@www.eyesopen.com>
| On Tue, 20 Dec 2005, Richard Earnshaw wrote:
| > tolower has EOF as part of its input domain, so I think you should
| > really make u1 and u2 ints; that's the natural type that a function
I'm not sure I agree with that part: when char is signed, the
promotion char -> int does not make positive values that originally
negative. So it appears to me that the cast to (unsigned char) is
necessary.
| > implementation (rather than a macro implementation) would take.
| > Effectively what you should be doing is applying the natural conversion
| > that would take place if tolower were not implemented as a macro.
|
| Many thanks. Here's the cast to int solution that I committed:
I think this solution is wrong.
-- Gaby