This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix memory leak in loop-unswitch.c

From: Sebastian Pop <sebastian dot pop at cri dot ensmp dot fr>
To: Ian Lance Taylor <ian at airs dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 12 Dec 2005 23:29:42 +0100
Subject: Re: Fix memory leak in loop-unswitch.c
References: <20051212180116.GB12911@napoca.cri.ensmp.fr> <m3r78i183b.fsf@gossamer.airs.com>

Ian Lance Taylor wrote:
> Sebastian Pop <sebastian.pop@cri.ensmp.fr> writes:
> 
> > Ok for mainline, 4.1 and 4.0?
> > 
> > 2005-12-12  Sebastian Pop  <pop@cri.ensmp.fr>
> > 
> > 	* loop-unswitch.c (unswitch_loop): Free zero_bitmap before returning.
> 
> This is OK, but while you're at it please change both calls to 'free'
> to 'sbitmap_free'.
> 
> (And bootstrap before committing, as usual.  You didn't say how it was
> tested.)
> 

Ouch, sorry: I have tested all the patches that I've sent all together
on amd64-linux, libjava failed on my machine as I didn't had a
required lib installed.  I will retest the patch with the proposed
change separately before committing.

Thanks,
Sebastian

References:
- Fix memory leak in loop-unswitch.c
  - From: Sebastian Pop
- Re: Fix memory leak in loop-unswitch.c
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]