Re: [PATCH] make it safe to include basic-block.h and tree-flow.h from C++

[Gabriel Dos Reis <gdr at integrable-solutions dot net>]

Andrew Pinski <pinskia@physics.uc.edu> writes:

| > 
| > Rafael Espíndola <rafael.espindola@gmail.com> writes:
| > 
| > | > Changing the name is the more correct fix.
| > | > as it will keep the code in line with the other code around it.
| > | 
| > | Ok. Should I change the name instead of the declaration in array.h too?
| > | 
| > | Bootstraped on GNU/Linux/x86
| > | Rafael
| > | 
| > | gcc/ChangeLog:
| > |               tree-flow.h: (edge_prediction): rename edge to e
| > |               predict.c:  rename edfe to e in edge_prediction
| > |               varray.h: (varray_data_tag): use struct rtx_def * instead of rtx
| > |                                                             use struct
| > | rtvec_def * instead of rtvec
| > |                                                             use union
| > | tree_node * instead of tree
| > 
| > Really funny you should post that.  I had the following patches
| > sitting in my local tree wince wednesday.  For consistency with rtl.h,
| > I prefixed the name of the fields with "va_".  I don't mind which
| > patch is applied, as long as the problem is solved and we have a
| > consistent way of doing things.
| 
| I want to say that va_ is not the correct thing used here as va for me
| has me thinking of variable argument and not varrays.  (note I wish that 
| varray will go away some time in the near future).

Is there a plan to for better candidate?

-- Gaby