[Patch] Transition from abort to gcc_assert

[Ryan Mansfield <RMansfield at qnx dot com>]

Patch to transition from abort to gcc_assert and gcc_unreachable. This
transition is mentioned at http://gcc.gnu.org/wiki/Partial%20Transitions.

Please let me know if I used gcc_assert/gcc_unreachable in any inappropriate
places. I tried to find as many uses of abort that could be replaced without
using gcc_assert to validate user input.

Since the patch is ~2750 lines (including context) should I break up the
patch into smaller chunks?

Regards, 

Ryan Mansfield

2005-12-09  Ryan Mansfield <rmansfield@qnx.com>
	* java-gimply.c (java_gimplify_expr): Use gcc_unreachable instead
	of abort.
	* typeck.c (set_local_type, parse_signature_type,
	parse_signature_string, build_java_signature, set_java_signature):
	Use gcc_assert and gcc_unreachable instead of abort.
	* parse.y (pop_current_osb, unreachable_stmt_error,
	obtain_incomplete_type, java_complete_class, 
	java_check_regular_methods, java_complete_expand_method, 
	cut_identifier_in_qualified,
find_applicable_accessible_methods_list,
	lookup_name_in_blocks, patch_binop, finish_for_loop): Likewise.
	* verify-impl.c (verify_instructions): Likewise.
	* class.c (build_class_ref, get_access_flags_from_decl, 
	get_interface_method_index): Likewise.
	* decl.c (update_aliases, check_local_unnamed_variable,
	java_replace_reference, start_java_method, get_stmts): Likewise.
	* jcf-parse.c (handle_deprecated, set_source_filename,
	get_name_constant, give_name_to_class, get_class_constant, 
	parse_zip_file_entries): Likewise.
	* constants.c (write_constant_pool): Likewise.
	* check-init.c (check_init): Likewise.
	* jcf-write.c (CHECK_PUT, CHECK_OP, maybe_free_localvar, 
	get_access_flags, find_constant_index, adjust_typed_op, emit_dup, 
	generate_bytecode_conditional, generate_bytecode_insns, 
	perform_relocations, generate_classfile): Likewise.
	* verify-glue.c (vfy_get_primitive_char, vfy_get_component_type): 
	Likewise.
	* managle.c (mangle_type, mangle_record_type, mangle_pointer_type,
	mangle_array_type): Likewise.
	* expr.c (push_type, java_stack_pop, java_stack_swap,
java_stack_dup,
	encode_newarray_type, build_java_arraystore_check,
expand_java_pushc,
	build_java_soft_divmod, pop_arguments, build_invokevirtual,
	build_invokeinterface, build_jni_stub, force_evaluation_order):
	Likewise.
	* lang.c (merge_init_test_initialization): Likewise.
	* boehm.c (mark_reference_fields): Likewise.


2005-12-09  Ryan Mansfield <rmansfield@qnx.com>	
	* objc-act.c (get_objc_string_decl, generate_static_references,
	add_objc_string, generate_protocol_list, synth_id_with_class_suffix,
	build_keyword_selector, objc_build_message_expr, 
	objc_build_selector_expr, check_methods_accessible,
	encode_type, encode_gnu_bitfield): Use gcc_assert and
gcc_unreachable
	instead of abort.

2005-12-09  Ryan Mansfield <rmansfield@qnx.com>
	* config/sh/sh.c (print_operand, replace_n_hard_rtx,
	sh_secondary_reload): Use gcc_assert and gcc_unreachable instead of
	abort.
	* config/sh/sh.md ("movdicc", 2 * sign extend -> logical op -> 
	truncate): Likewise.
	* config/crx/crx.c (crx_initial_elimination_offset, 
	crx_legitimate_address_p, crx_print_operand, 
	crx_print_operand_address): Likewise.
	* config/c4x/c4x.c (c4x_emit_move_sequence,  c4x_emit_libcall,
	c4x_valid_operands, c4x_adjust_cost): Likewise.
	* config/ia64/ia64.c	(ia64_load_pair_ok): Likewise.
	* config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin):
	Likewise.
	* config/rs6000/rs6000.c (def_builtin): Likewise.
	* gcc/config/arm/arm.c (legitimize_tls_address, arm_unwind_emit_stm,
	arm_unwind_emit_set, arm_unwind_emit): Likewise.

2005-12-09  Ryan Mansfield  <rmansfield@qnx.com>
	* misc.c (gnat_expand_expr, fp_prec_to_size, fp_size_to_prec): Use
	gcc_unreachable instead of abort.

2005-12-09  Ryan Mansfield <rmansfield@qnx.com>
	* tree1.c (my_malloc): Use gcc_unreachable instead of abort.
 
------
Attachments are virus free!

This message has been scanned for viruses at the originating end by
Nemx Anti-Virus for MS Exchange Server/IMC
	http://www.nemx.com/products/antivirus

Attachment: abort_cleanup.txt
Description: Text document