This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] make it safe to include basic-block.h and tree-flow.h from C++


> Actually your patch is incorrect and does not fix the real issue.
> The problem is in the struct edge_prediction.
> struct edge_prediction GTY((chain_next ("%h.next")))
> {
>   struct edge_prediction *next;
>   edge edge;
>   enum br_predictor predictor;
>   int probability;
> };
>
> You should change the name edge to something different.
> That will fix the issue without change all of edge in tree-flow.h.

I had to change only one edge definition in tree-flow.h: The one in
edge_prediction.
Changing the member name is likely to be a larger patch.

> -- Pinski
>

Rafael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]