Re: [autovect][patch] MIPS V2SF RTL patterns

["Chao-ying Fu" <fu at mips dot com>]

Yes.  I removed the unwanted double quotes, and attached the revised patch.
Thanks a lot!

Regards,
Chao-ying

----- Original Message ----- 
From: "Richard Sandiford" <richard@codesourcery.com>
To: "Chao-ying Fu" <fu@mips.com>
Cc: "Dorit Naishlos" <DORIT@il.ibm.com>; "Thekkath, Radhika"
<radhika@mips.com>; <gcc-patches@gcc.gnu.org>
Sent: Saturday, December 03, 2005 6:56 AM
Subject: Re: [autovect][patch] MIPS V2SF RTL patterns


> "Chao-ying Fu" <fu@mips.com> writes:
> >   This patch adds four RTL patterns for auto-vectorization.  I
> > compiled for the platform of mipsisa64-elf. One test (cxdot_fp) was
> > checked to see if auto-vectorization works.
>
> FWIW, this looks good from a MIPS point of view.  Just a very minor
> niggle:
>
> > +  "
> > +{
> > +  if (BYTES_BIG_ENDIAN)
> > +    emit_insn (gen_mips_puu_ps (operands[0], operands[1],
operands[2]));
> > +  else
> > +    emit_insn (gen_mips_pll_ps (operands[0], operands[2],
operands[1]));
> > +  DONE;
> > +}")
>
> These " quotes aren't needed, and cause problems if you then want to use
> double quotes in the C code.  Better just to write:
>
> > +{
> > +  if (BYTES_BIG_ENDIAN)
> > +    emit_insn (gen_mips_puu_ps (operands[0], operands[1],
operands[2]));
> > +  else
> > +    emit_insn (gen_mips_pll_ps (operands[0], operands[2],
operands[1]));
> > +  DONE;
> > +})
>
> Richard
>

Attachment: gcc.patch
Description: Binary data