This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fixproto failure on canadian cross


The comments around the fixproto Makefile rules indicate that this can/is only 
ever built when build==host. However the configure fragment also tests 
TARGET_SYSTEM_ROOT before setting STMP_FIXPROTO. This breaks canadian crosses 
(build!=host) when configured --with-sysroot.

I'm not sure what the correct fix is, but this seems a very strange 
conditional, and obviously broken. The simplest fix is to remove the test, 
and never run fixproto when doing a canadian cross.

Tested by building a i686-linux->i686-mingw32->m68k-elf cross. I don't really 
know what fixproto does, so I'm not sure what a proper test would be.
Ok for mainline and 4.1?

Paul

2005-11-23  Paul Brook  <paul@codesourcery.com>

	* configure.ac: Ignore TARGET_SYSTEM_ROOT when setting STMP_FIXPROTO.
	* configure: Regenerate.
Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 107376)
+++ gcc/configure.ac	(working copy)
@@ -1722,10 +1722,8 @@
 then
     BUILD_CFLAGS='$(INTERNAL_CFLAGS) $(T_CFLAGS) $(CFLAGS_FOR_BUILD)'
 
-    if test "x$TARGET_SYSTEM_ROOT" = x; then
-	if test "x$STMP_FIXPROTO" != x; then
-	  STMP_FIXPROTO=stmp-install-fixproto
-	fi
+    if test "x$STMP_FIXPROTO" != x; then
+	STMP_FIXPROTO=stmp-install-fixproto
     fi
 fi
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]