This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fortran/24787 -- SCAN is broken
On Fri, Nov 11, 2005 at 10:03:53AM +0100, Fran?ois-Xavier Coudert wrote:
> :REVIEWMAIL:
>
> > 2005-11-12 Steven G. Kargl <kargls@comcast.net>
> >
> > * intrinsics/string_intrinsics.c (string_scan): Off by one.
>
> Certainly looks OK to me, though I can't regtest it. A few details:
I'll wait a few more to give others a chance to pipe up.
> Your indentation looks not OK: with your patch, we will have
> if (back)
> {
> some more code
> }
I don't see this in my editor. The patch has
+ for (....
+ {
+
+ }
which may appear to look wrong, but lines with parentheses
contain tabs.
> > /* Verify that a set of characters contains all the characters in a
> > string by indentifying the position of the first character in a
> > - characters that dose not appear in a given set of characters. */
> > + characters that does not appear in a given set of characters. */
>
> indentifying --> identifying
>
> Though I don't understand what "the first character in a characters"
> means, but it might be my poor english playing tricks on me.
Fixed "identifying". Nothing wrong with your English. This
is one ugly comment, which I haven't attempted to rewrite.
--
Steve