Re: [Patch, fortran] PR24174 real(10) and complex(10) array IO broken.

[Brooks Moses <bmoses at stanford dot edu>]

FX Coudert wrote:
> Your patch is OK with the following comments:
> > ! { dg-do run }
> > ! { dg-require-effective-target fortran_large_real }
> > ! PR 24174 and PR 24305
> > program kind10_formatted_io
> >  ! This should be kind=10 on systems that support it
> >  integer, parameter :: k = selected_real_kind (precision (0.0_8) + 1)
>
> This comment it not right.  On some systems it will be kind=16 (systems 
> that do not have a real(kind=10)).

This depends on whether one presumes "it" in "systems that support it" 
to mean kind=10 or to mean selected_real_kind(precision(0.0_8)+1).

For the former presumption (which is what I understood it to mean), the 
comment is obviously correct.  For the latter presumption (which I 
gather is what you understood it to mean), it's not.

To make this completely clear, the comment could be rephrased as: "This 
should be 10 on systems that support kind=10," assuming that's what's 
actually meant.

- Brooks