This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Re: ref_contains_indirect_ref always false?
On Friday 04 November 2005 09:45, Richard Guenther wrote:
> On Fri, 4 Nov 2005, Diego Novillo wrote:
> > On Friday 04 November 2005 08:34, Richard Guenther wrote:
> > > * tree-flow-inline.h (ref_contains_indirect_ref): Deal
> > > with INDIRECT_REF not in handled_component_p.
> >
> > If you handle INDIRECT_REF directly, then you are seemingly changing
> > the semantics of the predicate. The predicate says that it's
> > expecting an ARRAY_REF as input.
> >
> > Point me to the bug you are trying to fix? There wasn't enough
> > context in your message.
>
> The bug is that as present, ref_contains_indirect_ref returns always
> false, regardless of input. Because handled_component_p returns false
> for TREE_CODE (arg) == INDIRECT_REF.
>
OK. In that case, let's use Kenner's version and add
#if defined ENABLE_CHECKING
gcc_assert (handled_component_p (ref))
#endif
at the start of both ref_contains_indirect_ref and ref_contains_array_ref.
The comment will need fixing, too. Both predicates are supposed to handle
aggregates in general.
Thanks.