This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch for bug c++/17964 (cpp error locations for C++)

From: Per Bothner <per at bothner dot com>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Gabriel Dos Reis <gdr at integrable-solutions dot net>
Date: Thu, 03 Nov 2005 14:51:55 -0800
Subject: Re: Patch for bug c++/17964 (cpp error locations for C++)
References: <Pine.LNX.4.64.0511020144100.22164@digraph.polyomino.org.uk> <4369B5BC.8080504@codesourcery.com>

Mark Mitchell wrote:

Joseph S. Myers wrote:

This patch fixes bug 17964, a regression in preprocessor diagnostics
for C++ caused by lexing up front but deferring string interpretation
(which depends on the parse context) until later, so the
preprocessor's notion of source location does not relate to the actual
source location at that point.

I think this is fine.

However, I want to give the cpplib and diagnostic maintainers a chance
to object.  If there are no objections within 24 hours, please go ahead
and commit.

No objections from me.

As Joseph points out, things would be simpler/cleaner if
--enable-mapped-location is made the default.  I really could
use some help with this ...
--
	--Per Bothner
per@bothner.com   http://per.bothner.com/

Follow-Ups:
- Re: Patch for bug c++/17964 (cpp error locations for C++)
  - From: Joseph S. Myers

References:
- Patch for bug c++/17964 (cpp error locations for C++)
  - From: Joseph S. Myers
- Re: Patch for bug c++/17964 (cpp error locations for C++)
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]