This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch,gfortran] PR 24245: ICE with -fdump-parse-tree


Quoting Erik Edelmann <erik.edelmann@iki.fi>:
> Attached is a patch to address these issues.
>
> One additional note:  The call to gfc_status() from
> show_symtree(), where we got the ICE, is commented out right now.
> This comes from the patch by Gaurav Gautam and Tobi, posted here:
> http://gcc.gnu.org/ml/fortran/2005-10/msg00713.html, which
> contains this part:
>
> --- gcc/fortran/dump-parse-tree.c       (revision 106030)
> +++ gcc/fortran/dump-parse-tree.c       (working copy)
> @@ -756,7 +756,9 @@ show_symtree (gfc_symtree * st)
>    gfc_status ("symtree: %s  Ambig %d", st->name, st->ambiguous);
>
>    if (st->n.sym->ns != gfc_current_ns)
> -    gfc_status (" from namespace %s", st->n.sym->ns->proc_name->name);
> +    /* Do nothing
> +       gfc_status (" from namespace %s", st->n.sym->ns->proc_name->name); */
> +    ;
>    else
>      gfc_show_symbol (st->n.sym);
>  }
>
> Since this part wasn't mentioned in the Changelog entry of that
> patch, I assume that it wasn't intentional (Tobi & Gaurav: is
> this assumption correct?). My patch uncomments the call to
> gfc_status() again.

This was unintentional, I ran into the segfault when debugging a testcase, and
then forgot about it later on.  I'll revert this, if you don't mind, as this
will make it clearer that it is not part of your patch.

- Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]