This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR fortran/18157 pointer to user-defined type andassignment
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Tue, 25 Oct 2005 19:26:58 +0200
- Subject: Re: [PATCH] Fix PR fortran/18157 pointer to user-defined type andassignment
- References: <200510251458.j9PEwD1q014572@earth.phy.uc.edu>
Andrew Pinski wrote:
> OK? Bootstrapped and tested on x86_64-pc-linux-gnu with no regressions.
>
> Also note I created three different testcases. The first two really should
> not need an temporary array but current uses one (someone else needs to look
> into that). The last one is the only one which really needs one.
Well, strictly speaking the third testcase doesn't need a temporary either, as
the loop can be reversed.
I have two comments:
> ChangeLog:
> * trans-array.c (gfc_conv_resolve_dependencies): Use the correct
> type of the temparory array.
^^^^^^^^^
s/temparory/temporary/ here and everywhere else.
> * trans-expr.c (gfc_trans_assignment): Pass lss instead of lss_section
> to gfc_conv_resolve_dependencies to get the correct type.
You need the same change in gfc_trans_where_assign as well (+ a corresponding
testcase).
Otherwise this is ok.
Thanks,
- Tobi