Re: [Patch, libgfortran] READ from the terminal is broken - 2nd patch - urgent review, please.

[Thomas Koenig <Thomas dot Koenig at online dot de>]

On Wed, Oct 12, 2005 at 07:17:28PM +0300, Janne Blomqvist wrote:

> No, not really. Your patch still touches fd_seek(). Attached patch is
> my proposal for a fix.
 
Is this really necessary?  This breaks one of the aims of your
original patch, which was to provide >2GB- records on 64-bit
systems.

If possible, I would prefer the following patch.  This only uses
a single read() for special files (like terminals) and do_read()
otherwise.

This is regression-tested on i686-pc-linux-gnu.  I would appreciate
if somebody could test it on a BSD-derived system to see that this
does fix the original problem.

Adding a test case for this bug will be ... interesting, requiring
integration of Dejagnu and pseudo terminals.  Ugh.  I hope everybody
agrees that we should waive the need for a test case here.

	Thomas

Attachment: unix.c-diff
Description: Text document