This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for libgfortran; broken isnan/isfinite/fpclassify
- From: FX Coudert <fxcoudert at gmail dot com>
- To: Steve Ellcey <sje at cup dot hp dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 27 Sep 2005 08:04:23 +0200
- Subject: Re: Patch for libgfortran; broken isnan/isfinite/fpclassify
- References: <200509262136.OAA29128@hpsje.cup.hp.com>
! #if (defined(fpclassify) && defined(HAVE_BROKEN_FPCLASSIFY))
! #undef fpclassify
! #endif
No need to check for defined(fpclassify), as Andrew Pinski told me about
a recent patch.
I am not sure what you mean by this check not being needed.
I'm just saying that:
#if (defined(fpclassify) && defined(HAVE_BROKEN_FPCLASSIFY))
#undef fpclassify
#endif
could be written as:
#if defined(HAVE_BROKEN_FPCLASSIFY)
#undef fpclassify
#endif
This is only a minor style issue, but it simplifies the code, so I'd go
for it (same thing for isnan and isfinite near that).
I'll fix the other issues and retest a modified patch before doing a
checkin.
Thanks for the work,
FX