This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for libgfortran; broken isnan/isfinite/fpclassify


> > ! #if (defined(fpclassify) && defined(HAVE_BROKEN_FPCLASSIFY))
> > ! #undef fpclassify
> > ! #endif
> 
> No need to check for defined(fpclassify), as Andrew Pinski told me about 
> a recent patch.
> 
> 
> FX

I am not sure what you mean by this check not being needed.  If I don't
find isnan or isfinite (or they are broken) and I do find fpclassify,
then I implement isnan and isfinite by using fpclassify.  On HP-UX our
fpclassify has the same problem as isnan and isfinite (it doesn't work
for long doubles), so I need to check if it is broken (it is) and not
use fpclassify on HP-UX to implement isnan and isfinite.

I'll fix the other issues and retest a modified patch before doing a
checkin.

If I didn't use fpclassify to implement isnan and/or isfinite then I
would not need this check as I removed the only use of fpclassify from
the library sources as part of this patch.

Steve Ellcey
sje@cup.hp.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]