This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix Fortran -fno-automatic and save_all (PR fortran/23677)
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Mon, 26 Sep 2005 10:58:01 +0200
- Subject: Re: [PATCH] Fix Fortran -fno-automatic and save_all (PR fortran/23677)
- References: <20050926083644.GT1020@devserv.devel.redhat.com>
Jakub Jelinek wrote:
> This patch fixes 2 problems:
> 1) SAVE all would not save constant length CHARACTER variables,
> but unexpectedly non-constant length CHARACTER variables
> (gfortran.fortran-torture/execute/save_1.f90 test passes
> with g77, but fails with gfortran unless this patch is applied)
> 2) -fno-automatic would issue errors if some variable had explicit
> SAVE already. g77 silently compiled it, so I think we should
> do the same.
> Ok for HEAD/4.0?
Your work might be relevant for PR 19425, which is an enhancement request. As
noted in PR 23677 -fno-automatic should really be a synonym for
-fmax-stack-var-size=0, that way the duplicate save problem wouldn't occur.
The fix for characters OTOH is a good catch.
- Tobi