This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Revised response-file patch
- From: DJ Delorie <dj at redhat dot com>
- To: mark at codesourcery dot com
- Cc: ian at airs dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 23 Sep 2005 17:05:03 -0400
- Subject: Re: Revised response-file patch
- References: <200509232051.j8NKprCX003037@sparrowhawk.codesourcery.com>
> OK to apply?
It looks OK to me, aside from a few optional aesthetic changes.
> + @code{*argcp} and @code{*argvp} will be updated. If the value of
> + @code{*argvp} is modified by this function, then the new value has
> + been dynamically allocated and should be deallocated by the caller
> + with @code{freeargv}.
We should probably mention that we don't *expect* applications to ever
check this, nor call freeargv even if needed. IMHO we expect
most applications to just blindly call:
expandargv (&argc, &argv);
and not worry about it after that.
Blank lines would be nice at these locations:
> + int argv_dynamic = 0;
> + /* Loop over the arguments, handling response files. We always skip
> + size_t file_argc;
> + /* We are only interested in options of the form "@file". */
> + free (buffer);
> + error: