Re: [PATCH] Speedup IMA by speeding up comp_types

[Geoff Keating <geoffk at geoffk dot org>]

Hi Andrew,

+/* This is a cache to hold if two types are compatiable or not. */
+
+struct tagged_tu_seen_cache {
+  const struct tagged_tu_seen_cache * next;
+  tree t1;
+  tree t2;
+  /* The return value of tagged_types_tu_compatible_p if we had seen
+     these two types already.  */
+  int val;
+};
+
+/* Can they be compatible with each other?  We choose to break the
+   recursion by allowing those types to be compatible.  */

You changed the comment, but now it makes no sense.  I think you'll  
want to delete the comment after the structure.  (Also, there's an  
extra 'a' in "compatiable", and there should be two spaces after the  
'not.'.)

Also, please put a newline between these pairs of lines:

+}
+/* Return 1 if TYPE1 and TYPE2 are compatible types for assignment

+  tagged_tu_seen_base = tu;
+  /* The C standard says that two structures in different translation

it'll make it easier to read.  OK with those changes.

Attachment: smime.p7s
Description: S/MIME cryptographic signature